[minikube]:windows node setup #4
Conversation
* extend the minikube start command to accept windows os node flag --------- Co-authored-by: Steven Powell <[email protected]>
* Download and cache Windows ISO to preloads folder on request
…ws node (#2) * extended minikube node add command with flags for adding a windows node Co-authored-by: Steven Powell <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated 6 comments.
Files not reviewed (5)
- pkg/minikube/bootstrapper/bootstrapper.go: Evaluated as low risk
- pkg/minikube/config/types.go: Evaluated as low risk
- pkg/minikube/constants/constants.go: Evaluated as low risk
- pkg/minikube/bootstrapper/certs.go: Evaluated as low risk
- pkg/minikube/machine/client.go: Evaluated as low risk
Comments suppressed due to low confidence (4)
pkg/minikube/node/powershell.go:21
- The variable 'powershell' should be checked to ensure it is not empty after 'exec.LookPath'. If 'powershell' is not found, an error should be returned.
powershell, _ = exec.LookPath("powershell.exe")
pkg/minikube/node/powershell.go:35
- [nitpick] The function 'cmdOut' should return stderr in case of an error to make debugging easier.
return stdout.String(), err
pkg/minikube/node/start.go:1073
- [nitpick] The error message could be more descriptive. Consider providing more context about the command that failed.
klog.Infof("couldn't run %q command. error: %v", rr.Command(), err)
pkg/minikube/node/start.go:389
- The new behavior for Windows nodes should be covered by tests to ensure it works as expected.
joinCmd, err = cpBs.GenerateTokenWindows(*starter.Cfg)
|
@bobsira Tested this locally and it works fine. nit: Checked the |
|
@bobsira Thankyou for the PR, I tested it on windows machine , It looks good to me, im able to spawn 2 different minikube nodes one with buildroot and other with windows server 2025. |
|
Any updates on this? |
Hello @mloskot — we are targeting inclusion of this functionality in the next Minikube release. For context, the Minikube maintainers are currently consolidating the minikube-machine repository into the main minikube repository. As a result, the changes implemented in this PR will need to be migrated into the Minikube repo once that consolidation is complete. The expectation is that this consolidation will be finalized ahead of the next release, allowing the work to be carried over without blocking the release timeline. |
|
@bobsira Thank you very much for the update and for the hard work you've done her! |
bobsira
force-pushed
the
feature/windows-node-support
branch
from
528d214 to
92e53aa
Compare
Testing Instructions for this PR
🛠 Prerequisites (Local Machine)
Local Repositories
Environment & Tools
make.1) Build Minikube
From the root of the
minikuberepository:Run from Git Bash:
make2) Start a Hybrid Cluster (Elevated PowerShell Required)
Important
From the root of the repository, run:
Basic Usage (Built-in Windows VHD)
.\minikube.exe start --kubernetes-version=v1.32.3 -n 2 --node-os='[linux,windows]'What this does:
🛠 Using a Custom Windows VHD
The
--windows-vhd-urlflag allows you to supply your own Windows Server VHDX image. This can be either:Note
The VHD must already contain:
Remote
.\minikube.exe start --kubernetes-version=v1.32.3 -n 2 --node-os='[linux,windows]' --windows-vhd-url='https://<your-storage>/hybrid-minikube-windows-server.vhdx'Local path
.\minikube.exe start --kubernetes-version=v1.32.3 -n 2 --node-os='[linux,windows]' --windows-vhd-url='C:\vhd\hybrid-minikube-windows-server.vhdx'Minikube will:
3) Verify Cluster State
Once
minikube startcompletes:kubectl get nodes -o wideshould show two nodes with OS labels: one linux, one windows.Setting up the cluster
Verify your cluster
